Closes 5170 adding overloads to reshape #5212
Open
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
reviewed
Dec 22, 2025
1RyanK
approved these changes
Jan 13, 2026
| def reshape(self, *shape: int_scalars) -> pdarray: ... | ||
|
|
||
| @overload | ||
| def reshape(self, shape: pdarray) -> pdarray: ... |
Collaborator
There was a problem hiding this comment.
Should we add an @overload for numpy arrays?
In [18]: shape_np = np.array([6, 4], dtype=np.int64)
...: try:
...: a.reshape(shape_np)
...: except Exception as e:
...: print(type(e).__name__, e)
...:
TypeError type of argument "shape"[0] must be one of (int, int8, int16, int32, int64, uint8, uint16, uint32, uint64, Sequence, pdarray); got numpy.ndarray instead
Contributor
There was a problem hiding this comment.
That's a good idea but it could also be a separate ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5170.
This adds overloads to reshape.
It also fixes a bug in test_flatten_multidim. The expression
a.reshape(2,2,size/4)has been changed toa.reshape(2,2,size//4). The reason is that size/4 is interpreted as a float, and floats aren't allowed in a shape. This is consistent with numpy.